Update ZAP Go Package, Fix Generation Issues, and Autogenerate Interface #21
Conversation
|
To address the DCO requirement you'll need to sign-off the commit(s): |
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
Signed-off-by: Alessio Dalla Piazza <[email protected]>
alessiodallapiazza
force-pushed
the
master
branch
from
d81db65 to
32a8927
Compare
|
Hello, |
|
|
||
| zaproxy/ | ||
| zap-extensions/ |
There was a problem hiding this comment.
These should be removed, the repos should live at the same level as the zap-api-go not under it.
There was a problem hiding this comment.
What if we link these two projects as submodules instead? This way, users won't need to clone them manually into the correct location. I added them to the .gitignore file to ensure they are not committed accidentally.
There was a problem hiding this comment.
The repos are already cloned, per dev guide.
There was a problem hiding this comment.
This seems wrong, why are they prefixed with zap-api-go now? Was that because of the clone under the repo?
There was a problem hiding this comment.
There might have been some changes in the generation script. I followed the instructions in the README and executed the commands using Gradle.
There was a problem hiding this comment.
In that case the instructions were not followed correctly.
| @@ -1,264 +1,246 @@ | |||
| // Zed Attack Proxy (ZAP) and its related class files. | |||
There was a problem hiding this comment.
The interface.go file is now automatically generated using a bash script. I will update the template to include the previous comments.
| // limitations under the License. | ||
|
|
||
| // TODO: auto generate this file | ||
| // Package zap defines the interface a ZAP client should implement | ||
| package zap | ||
|
|
||
| // Interface defines the interface a ZAP client should implement | ||
| type Interface interface { |
There was a problem hiding this comment.
I will sort them in the bash script 👍
Hello,
I would like to try the ZAP API, but I noticed that the Go package is not updated, which is discouraging for users who want to use it with Go. As a result, I decided to fork the repository and implement some updates and fixes. Here are the changes I made:
Readme Update:
Updated the README file to reflect the latest changes and improvements.
Autogenerated Interface:
Created a script to autogenerate the
interface.gofile to accommodate the updated interfaces.Ensured the interfaces reflect the current structure and functionality.
Folder Structure Changes:
Adjusted the folder structure to align with the new generation process.
I hope these changes are helpful. Please let me know if there are any additional modifications or improvements needed.
Best regards,